Skip to content

Faster ArrayType->hasOffsetValueType() #4288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

Faster ArrayType->hasOffsetValueType() #4288

merged 2 commits into from
Sep 5, 2025

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 5, 2025 •
edited
Loading

closes phpstan/phpstan#13455

with this PR:

➜  phpstan-src git:(faster12) ✗ time php bin/phpstan analyze bug-12800.php --debug
Note: Using configuration file /Users/staabm/workspace/phpstan-src/phpstan.neon.dist.
/Users/staabm/workspace/phpstan-src/bug-12800.php
php -v ------ --------------------------------------------- 
  Line   bug-12800.php                                
 ------ --------------------------------------------- 
  5      Class Bug12800\a must be abstract or final.  
         🪪  phpstan.finalClass                       
 ------ --------------------------------------------- 


                                                                                                                        
 [ERROR] Found 1 error                                                                                                  
                                                                                                                        

php bin/phpstan analyze bug-12800.php --debug  3.50s user 0.18s system 99% cpu 3.684 total

VincentLanglet
VincentLanglet reviewed Sep 5, 2025
View reviewed changes
Copy link
Contributor

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the same in ConstantArrayType

@staabm staabm mentioned this pull request Sep 5, 2025
Closed
@staabm staabm marked this pull request as ready for review September 5, 2025 10:25
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit 4432832 into phpstan:2.1.x Sep 5, 2025
440 of 454 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the faster12 branch September 5, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@VincentLanglet VincentLanglet VincentLanglet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate slow tests / perf regression

4 participants

@staabm @phpstan-bot @ondrejmirtes @VincentLanglet